feat: enhancements June 2025#28
Merged
Merged
Conversation
update inspector to use paths and O(1) lookups
…xsync.v4 updates a few tests and adds a new one for Olla specifically.
# Conflicts: # internal/adapter/proxy/proxy_sherpa.go
Indent shutdown startup time
make version a bit more aligned
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a suite of enhancements for June 2025, including request‐level logging, a new generic EventBus system with tests, and improved header filtering in the Sherpa proxy.
- Adds
request_loggingtoggle and middleware to HTTP handlers - Implements
EventBus[T]with full test coverage - Filters unsafe headers and injects proxy headers in Sherpa engine
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| readme.md | Updated features, config options, and usage examples |
| pkg/eventbus/eventbus.go (+ tests) | Added lock-free EventBus implementation and tests |
| internal/app/handlers/server.go | Introduced request‐logging middleware |
| internal/adapter/proxy/proxy_sherpa.go | Added header filtering and proxy metadata headers |
| internal/logger/styled_pretty.go | Extended logger interface (missing import) |
| internal/logger/styled_plain.go | Extended logger interface (missing import) |
| internal/version/version.go | Bumped version placeholder |
Comments suppressed due to low confidence (5)
internal/version/version.go:18
- [nitpick] The version placeholder "v0.0.x" should be updated to an actual release version or managed via build tooling.
Version = "v0.0.x"
internal/logger/styled_pretty.go:29
- This method calls fmt.Sprintf and fmt.Print but the fmt package is not imported. Please add
import "fmt".
func (sl *PrettyStyledLogger) InfoWithStatus(msg string, status string, args ...any) {
internal/logger/styled_plain.go:21
- This method uses fmt.Print but the fmt package is not imported. Please add
import "fmt".
func (sl *PlainStyledLogger) ResetLine() {
internal/app/handlers/server.go:60
configServeris undefined in this scope. It should reference the application configuration (e.g.,a.Config.Server.RequestLogging).
if configServer.RequestLogging {
internal/adapter/proxy/proxy_sherpa.go:390
constants.ProtocolHTTPSandconstants.ProtocolHTTPare not defined or imported. Consider using literal strings "https"/"http" or import the correct package.
protocol = constants.ProtocolHTTPS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements in June